-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Vim like movement commands #4204
Closed
mitsuhiko
wants to merge
12
commits into
helix-editor:master
from
mitsuhiko:feature/vim-like-line-movement
Closed
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ec4434d
Implement Vim like movement commands
mitsuhiko 205e3a1
Added move_line_up_anchored and move_line_down_anchored
mitsuhiko 66fa94b
Remove move_from_line_end
mitsuhiko 0af9776
Remember the newline move mode on the range
mitsuhiko 98997a3
Remove newline_move_mode flag from range
mitsuhiko d18736e
line_bounded -> same_line
mitsuhiko 640f288
Revert some unnecessary changes
mitsuhiko b3ea679
Simplify same line movement
mitsuhiko 07517f5
Update a docstring
mitsuhiko cef16f1
Use rope_is_line_ending
mitsuhiko 8d7fe06
Added extend versions of commands
mitsuhiko 3469461
Apply suggestions from code review
mitsuhiko File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have some tests for both of these functions?