mouse operations respect scrolloff #5255
Conversation
helix-term/src/ui/editor.rs
Outdated
| Some(pos) => pos, | ||
| None => return EventResult::Ignored(None), | ||
| }; | ||
| if let Some((pos, view_id)) = pos_and_view(editor, row, column) { |
There was a problem hiding this comment.
Why the change from pos_at_screen_coords on the current view to pos_and_view here? Dragging should only affect the currently focused view: with this change, if you start a drag on a focused view and then drag across an unfocused view, you modify the selection on the unfocused view but you can't see the selection because selections are hidden on unfocused views.
There was a problem hiding this comment.
I did not realize that there are different between pos_at_screen_coords and pos_and_view beside beside pos_and_view also return view.id. I will change it.
| @@ -1213,6 +1216,7 @@ impl EditorView { | |||
| commands::scroll(cxt, offset, direction); | |||
|
|
|||
| cxt.editor.tree.focus = current_view; | |||
| cxt.editor.ensure_cursor_in_view(current_view); | |||
There was a problem hiding this comment.
Is this change necessary? commands::scroll already respects scrolloff
There was a problem hiding this comment.
Currently the commands::scroll does respects scrolloff. However, if the file like this:
----------------------------| visible at this point--------------| cursor here
longlonglonglonglonglonglonglonglonglonglonglonglonglonglonglong[]onglonglonglong
longlonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglong
longlonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglong
longlonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglong
short or empty
short or empty
short or empty
short or empty
short or empty
after scroll down
--------------| cursor here | still visible at this point
longlonglonglonglonglonglonglonglonglonglonglonglonglonglonglong[]onglonglonglong
longlonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglong
longlonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglong
longlonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglong
short or empty
short or empty
short or empt[]
short or empty
short or empty
the cursor will not be visible and not respects scrolloff.
change pos_and_view back to pos_at_screen_coords
hunterliao29
force-pushed
the
mouse_respect_scrolloff
branch
from
de52c10
to
fa9f848
Compare
close #5254