highlight non-bar cursors #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-enhancement
pickfire
approved these changes
Jan 18, 2023
|
Thanks Pascal, this fixes a visual annoyance and had learned to live with. Looking forward to the next release as I didn't install dev builds so far. Maybe something I should practice though :-) |
kirawi
pushed a commit
to kirawi/helix
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1568
The logic is a bit more complicated than originally described in the issue. I think all non-block cursors don't show well that the cursor is part of the selection. Therefore, the cursor is always highlighted as a selection now. To avoid weird looking regressions in insert mode I added two special cases so that
a(andiwith just a single grapheme selected) don't regress.