Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSBuild language based on XML grammar #5793

Merged
merged 2 commits into from Feb 3, 2023

Conversation

brettlyons
Copy link
Contributor

@the-mikedavis the-mikedavis linked an issue Feb 2, 2023 that may be closed by this pull request
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to add syntax highlighting, you will need to create some files in runtime/queries/msbuild/: highlights.scm, injections.scm and indents.scm. All of these should just have the contents

; inherits: xml

That will re-use the XML tree-sitter queries for syntax highlighting and indentation.

Also, you will need to run cargo xtask docgen and commit the changes to add msbuild support to the documentation. (This will fix the CI.)

languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Feb 2, 2023
@the-mikedavis the-mikedavis changed the title Added MSBuild to languages.toml based on XML grammar Add MSBuild language based on XML grammar Feb 3, 2023
@the-mikedavis the-mikedavis merged commit d8f482e into helix-editor:master Feb 3, 2023
@the-mikedavis
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration for MSBuild files
2 participants