feat: lint for ui.virtual and catch present and future virtual based features
#6320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
requested changes
Mar 15, 2023
Maybe you're right that this setting will not feel broken given the existence of a virtual key. I'm just trying to help make the feeling of helix (and especially changing themes) a bit less broken. I'll check as soon as I get on my computer today and close this if setting inlay-hints simply works across the board. I should've checked... Thanks |
|
I agree. The themes that look off/wrong are all missing |
AlexanderBrevig
changed the title
ui.virtual and catch present and future virtual based features
sagnibak
pushed a commit
to sagnibak/helix
that referenced
this pull request
Mar 21, 2023
…d features (helix-editor#6320) * feat: lint for inlay-hint.parameter and .type * fix: lint against ui.virtual and not the new inlay-hint specifically
icecreammatt
pushed a commit
to icecreammatt/helix
that referenced
this pull request
Apr 19, 2023
…d features (helix-editor#6320) * feat: lint for inlay-hint.parameter and .type * fix: lint against ui.virtual and not the new inlay-hint specifically
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
…d features (helix-editor#6320) * feat: lint for inlay-hint.parameter and .type * fix: lint against ui.virtual and not the new inlay-hint specifically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #5934 closed #2070 I think the linter should check for these.
Maybe it's about time that we run the linter against PRs with changes to
/runtime/themes?EDIT: this now lints for
ui.virtualas a catch all for present and future virtual text.