Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Smithy support #6370

Merged
merged 7 commits into from
Mar 21, 2023
Merged

Add initial Smithy support #6370

merged 7 commits into from
Mar 21, 2023

Conversation

zetashift
Copy link
Contributor

Adds syntax highlighting support for https://smithy.io/2.0/index.html a meta-modeling language to describe APIs.

LSP: https://github.com/disneystreaming/smithy-language-server
Treesitter grammar: https://github.com/indoorvivants/tree-sitter-smithy

languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
runtime/queries/smithy/highlights.scm Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis merged commit 0e0c16e into helix-editor:master Mar 21, 2023
@the-mikedavis
Copy link
Member

Thanks! Could you add a note about coursier to the language server wiki? https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers

@zetashift
Copy link
Contributor Author

@mtdowling
Copy link

This is awesome @zetashift. Any reason you used the Disney version instead of the version maintained by AWS? The AWS version has additional fixes like not crashing if there isn't a smithy-build.json file. It can also be installed through Coursier (via their contrib channel) using:

cs launch --contrib smithy-language-server -- 0

@zetashift
Copy link
Contributor Author

zetashift commented Apr 3, 2023

This is awesome @zetashift. Any reason you used the Disney version instead of the version maintained by AWS?

Hi @mtdowling! At first I wanted to use the version maintained by AWS, but when I was looking at what neovim's mason plugin does: https://github.com/mason-org/mason-registry/pull/148/files#diff-842575865783293dbaedbb7d5de0a10794860d0a04d6e26acd437927d206baae I kinda got scared and just went with Disney's, because that one has a simple coursier install command, and I am more familiar with Scala.

But able to use coursier for the AWS one changes things quite a lot for me... :P.

How about I make a new PR that uses the LS of AWS and coursier?

EDIT: or if you know of better "run the LS" programs/commands I can look into that too, I just made this PR on whatever got me up and running the quickest

@mtdowling
Copy link

Yeah a PR to use the AWS version would be awesome!

or if you know of better "run the LS" programs/commands I can look into that too, I just made this PR on whatever got me up and running the quickest

For now, using cs launch --contrib smithy-language-server -- 0 seems like the right approach. We might figure out a better way in the future to do something more self contained, but don't have that yet.

@zetashift
Copy link
Contributor Author

Yeah a PR to use the AWS version would be awesome!

Thank you for the coursier tip, the PR is up: #6370 (comment)

icecreammatt pushed a commit to icecreammatt/helix that referenced this pull request Apr 19, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants