Robust snippet parsing #6371
Merged
Robust snippet parsing #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-bug
pascalkuthe
force-pushed
the
robust_snippet_parsing
branch
from
2fe53dc
to
4dab531
Compare
Urgau
approved these changes
Mar 21, 2023
| fn anything<'a>(escape_chars: &'static [char]) -> impl Parser<'a, Output = SnippetElement<'a>> { | ||
| fn anything<'a>( | ||
| escape_chars: &'static [char], | ||
| end_at_brace: bool, |
There was a problem hiding this comment.
bool as parameter aren't pretty. Maybe directly specifying a const instead?
Suggested change
| end_at_brace: bool, | |
| extra_chars: &'static [char], |
There was a problem hiding this comment.
Ah sorry, I meant to answer this but somehow my comment didn't get posted. Even with const generics this is not that easy to do since we need to add $ to the slice. It's possible to do this with a bunch of fancy array tricks + const generic magic (or by allocating a vec) but I think a simple bool parameter is preferable to that. If we actually need something else than a bracket here we can revisit
the-mikedavis
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6347
Fixes a bunch of small bugs in the snippet parsing, mostly relating to escape sequences. The LSP standard is incomplete, ambigous/missleading and sometimes even downright wrong so I just used the vscode implementation as a reference. I have started porting a bunch of tests over from there to be sure we are doing the right thing now. However due to the sheer number of tests I stopped with that at some point to preserver my sanity.
The large number of inserted lines are just tests, the code changes itself are pretty minor.