Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update upstream tree-sitter-dockerfile #6895

Merged
merged 3 commits into from
May 12, 2023
Merged

fix: update upstream tree-sitter-dockerfile #6895

merged 3 commits into from
May 12, 2023

Conversation

mcdoker18
Copy link
Contributor

@mcdoker18 mcdoker18 commented Apr 27, 2023 •
edited
Loading

Fixes: #6797

the-mikedavis
the-mikedavis reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is a new node mount_param (and mount_param_param under that) that should be added to the highlight queries in runtime/queries/dockerfile/highlights.scm

See grammar.js in the comparison camdencheek/tree-sitter-dockerfile@7af32bc04a66ab196f5b9f92ac471f29372ae2ce...8ee3a0f7587b2bd8c45c8cb7d28bd414604aec62#diff-919ac210ac

@mcdoker18
Copy link
Contributor Author

It looks like there is a new node mount_param (and mount_param_param under that) that should be added to the highlight queries in runtime/queries/dockerfile/highlights.scm

See grammar.js in the comparison camdencheek/tree-sitter-dockerfile@7af32bc04a66ab196f5b9f92ac471f29372ae2ce...8ee3a0f7587b2bd8c45c8cb7d28bd414604aec62#diff-919ac210ac

I added the highlight for param and mount_param.

after

@pascalkuthe pascalkuthe merged commit 5938e2c into helix-editor:master May 12, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
@mcdoker18 @Triton171
fix: update upstream tree-sitter-dockerfile (helix-editor#6895)
7c3f5d5 
* fix: update upstream tree-sitter-dockerfile

Fixes: helix-editor#6797

* fix: review

* fix: review
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@mcdoker18 @wes-adams
fix: update upstream tree-sitter-dockerfile (helix-editor#6895)
c8ae0fa 
* fix: update upstream tree-sitter-dockerfile

Fixes: helix-editor#6797

* fix: review

* fix: review
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@mcdoker18
fix: update upstream tree-sitter-dockerfile (helix-editor#6895)
5c0fafd 
* fix: update upstream tree-sitter-dockerfile

Fixes: helix-editor#6797

* fix: review

* fix: review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree sitter dockerfile: Error on USER 1000:100
3 participants
@mcdoker18 @the-mikedavis @pascalkuthe