Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize completion doc position. #691

Merged
merged 15 commits into from
Sep 8, 2021

Conversation

cossonleo
Copy link
Contributor

@cossonleo cossonleo commented Sep 1, 2021

The completion doc will render on right area of completion menu when it is enough.

2021-09-02_17-22

@pickfire
Copy link
Contributor

pickfire commented Sep 2, 2021

Does the doc position change? Maybe a screenshot to show the differences if there is?

@cossonleo
Copy link
Contributor Author

Does the doc position change? Maybe a screenshot to show the differences if there is?

I had uploaded a screnshot.

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not tested.

@archseer archseer merged commit 011f9aa into helix-editor:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants