GN language support #6969
Merged
GN language support #6969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
requested changes
May 4, 2023
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
kirawi
added
S-waiting-on-review
the-mikedavis
added
S-waiting-on-author
|
Thanks for the quick review! The tree-sitter stuff is a bit new to me, I tried to fix it up. |
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
the-mikedavis
added
S-waiting-on-review
|
Should I resolve the conflicts? Will this be accepted? |
|
I think this is a good addition - could you resolve the conflicts? For context, GN here is google's ninja generator system it uses for chromium, right? |
|
Yes, it's used with the ninja build system, which is used by Chromium, Flutter, Android, Skia (although some of those are moving more towards Bazel at this point). |
the-mikedavis
approved these changes
Nov 18, 2023
acristoffers
pushed a commit
to acristoffers/helix
that referenced
this pull request
Nov 18, 2023
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @willcassella for doing the actual work here.
Comments in the query files indicate some things aren't quite right, but it works well enough for me.
Fixes #6968