Fix panic when buffer larger than terminal width #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And this doesn't have any unexpected side effects? Such as wrapping the cursor into places it really shouldn't be? |
|
I didn't see any when testing and I don't see why it would. This change should only affect the situation when underflow occurs and it panics, since I replaced the raw subtract with saturating_sub. If it does cause such an error then there is probably an architectural problem. Edit: There is a visual bug that occurs on resizing the window, where if the cursor is at the end of the window and the text exceeds the terminal width, increasing the window size doesn't move the text to accommodate for the new room, but I get that regardless of this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #69.