Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DAP vars popup, instead of adding new #7034

Merged
merged 1 commit into from May 13, 2023
Merged

Replace DAP vars popup, instead of adding new #7034

merged 1 commit into from May 13, 2023

Conversation

A-Walrus
Copy link
Contributor

Steps to reproduce original issue:

  • Add breakpoint
  • Start debugging
  • Program stops at breakpoint
  • List variables
  • Step to next
  • List variables again
    Before:
    image

pascalkuthe
pascalkuthe approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pascalkuthe pascalkuthe added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels May 13, 2023
@the-mikedavis the-mikedavis merged commit d5fe08d into helix-editor:master May 13, 2023
6 checks passed
@A-Walrus A-Walrus deleted the dap_vars branch May 13, 2023 15:54
aotarola pushed a commit to aotarola/helix that referenced this pull request May 28, 2023
@A-Walrus @aotarola
Replace DAP vars popup, instead of adding new (helix-editor#7034)
a3b2b85
aotarola pushed a commit to aotarola/helix that referenced this pull request May 28, 2023
@A-Walrus @aotarola
Replace DAP vars popup, instead of adding new (helix-editor#7034)
74123ec
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
@A-Walrus @Triton171
Replace DAP vars popup, instead of adding new (helix-editor#7034)
5289f05
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@A-Walrus @wes-adams
Replace DAP vars popup, instead of adding new (helix-editor#7034)
b5b6de3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@A-Walrus @the-mikedavis @pascalkuthe