Replace_document_in_view() applies the last known view for documents

[t-monaghan]

This PR is to address issue #7355

[dead10ck]

This looks good to me, thanks!

[pascalkuthe]

This only works with a single view, not multiple views. Not only would they smudge last_view_position but the view offset can shift by various edits so that the position doesn't shift when the file is edited in another view. So the right way to fix this would be to store view offsets on the document per view and map them through changes. At that point, it doesn't make sense to differentiate between the last view position and the current view position. Instead, just store them all on the document. This is a general pattern we have been seeing (storing stuff on the document instead of view to map them through changes). Its sort of starting to bloat the document tough so we likely want some kind of shared ViewData struct for that. There was some discussion about that in #6198

[t-monaghan]

@pascalkuthe I'm not quite across the intended behaviour for multiple views. Could I ask you to have a look at this recording and let me know if it demonstrates the smudging/shifting that you've raised? https://asciinema.org/a/8F4fvSJB4rY0tgtwJvXuJXUCy

[pascalkuthe]

the intended behavoiur is that every view has its own position in the document. Basically views should not change others positions. so if I have file X open in views A and B at positions F and G respectively and switch to file Y in both views and then bach to X then A should endup at position F and B at position G again.

[the-mikedavis]

Let's close this in favor of #7568