Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typst language and lsp #7474

Merged
merged 14 commits into from Oct 26, 2023

Conversation

AlexanderBrevig
Copy link
Contributor

@AlexanderBrevig AlexanderBrevig commented Jun 28, 2023

image

Will add to the wiki when/if merged.

Closes #6688

@AlexanderBrevig
Copy link
Contributor Author

https://typst.app/docs/

languages.toml Outdated Show resolved Hide resolved
@kirawi kirawi added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jun 30, 2023
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
the-mikedavis
the-mikedavis previously approved these changes Jul 9, 2023
@Phant80m
Copy link

Phant80m commented Aug 8, 2023

This would be useful

@erasin
Copy link
Contributor

erasin commented Aug 20, 2023

#6688

languages.toml Outdated Show resolved Hide resolved
@uben0
Copy link

uben0 commented Sep 17, 2023

I am not big on pull request (never done it). But, is it possible to change the grammar to my own on the pull request?
I wrote and maintain a grammar which is complete at https://github.com/uben0/tree-sitter-typst
Or should I create another pull request?

@fufexan
Copy link

fufexan commented Sep 17, 2023

@uben0 either ask @AlexanderBrevig to use your grammar, or open a PR.

You can get this PR's diff here and apply it to your helix clone with git apply -p1 < typst.patch. Then you can modify the grammar to point to your repo.

@gabydd
Copy link
Member

gabydd commented Sep 17, 2023

Just fyi @uben0 to be able to add it to helix you'll need to check in these files https://github.com/uben0/tree-sitter-typst/blob/master/.gitignore#L5-L8 (all the ones generated by the cli) I have been using your grammar for a couple days and it does seem the most complete so I agree with using it

@AlexanderBrevig
Copy link
Contributor Author

I will update this PR

@AlexanderBrevig
Copy link
Contributor Author

Just fyi @uben0 to be able to add it to helix you'll need to check in these files https://github.com/uben0/tree-sitter-typst/blob/master/.gitignore#L5-L8 (all the ones generated by the cli) I have been using your grammar for a couple days and it does seem the most complete so I agree with using it

Will you let me know @uben0 when the files are in the repo?
Nice work BTW!

@uben0
Copy link

uben0 commented Sep 18, 2023 via email

@AlexanderBrevig
Copy link
Contributor Author

Updated TS grammar to https://github.com/uben0/tree-sitter-typst

Thank you @uben0!

image

@uben0
Copy link

uben0 commented Sep 18, 2023 via email

Copy link

@realeinherjar realeinherjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just get the @the-mikedavis changes in

the-mikedavis
the-mikedavis previously approved these changes Sep 27, 2023
@realeinherjar
Copy link

Too bad that this could not be in 23.11 :(

@lydiandy
Copy link
Contributor

lydiandy commented Oct 26, 2023

Too bad that this could not be in 23.11 :(

I try it again in the latest hx.
it is ok.

@pascalkuthe pascalkuthe merged commit 2906660 into helix-editor:master Oct 26, 2023
6 checks passed
@cinerea0
Copy link
Contributor

Too bad that this could not be in 23.11 :(

Agreed, given the five months between the previous release and the latest one.

@Idobenhamo
Copy link
Contributor

@AlexanderBrevig Maybe it is worth it to update the tree sitter to the newest version to support typst 0.9

@uben0
Copy link

uben0 commented Nov 1, 2023

I'll work on it

@uben0
Copy link

uben0 commented Nov 3, 2023

I have been checking the change log for Typst 0.9 and it seams like the only change related to syntax is the addition of builtin quote function. I can't find any other change related to syntax. Can anyone double check this?

acristoffers pushed a commit to acristoffers/helix that referenced this pull request Nov 18, 2023
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
danillos pushed a commit to danillos/helix that referenced this pull request Nov 21, 2023
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there any plan to support typst?