Initialize log and config files right after parsing arguments #7585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alevinval
commented
Jul 9, 2023
helix-term/src/main.rs
Outdated
| helix_loader::initialize_config_file(args.config_file.clone()); | ||
| helix_loader::initialize_log_file(args.log_file.clone()); | ||
|
|
||
| setup_logging(args.verbosity).context("failed to initialize logging")?; |
There was a problem hiding this comment.
Technically it could be moved right before --health, I can do that. In terms of future-proofing, I think doing it as soon as possible is best.
There was a problem hiding this comment.
I see that fetch/build grammars and health do not use logging, but I still moved That's probably overkill, leaving it where it was.setup_logging to the top. I can leave it where it was if you disagree.
pascalkuthe
approved these changes
Jul 9, 2023
the-mikedavis
approved these changes
Jul 9, 2023
the-mikedavis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either after parsing arguments or before running the
--healthlogic, since that one already requires access to theconfigdir. I'd say it's better to play it safe and put it right after parsing arguments.