Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add everforest dark theme #760

Merged
merged 1 commit into from Sep 17, 2021
Merged

add everforest dark theme #760

merged 1 commit into from Sep 17, 2021

Conversation

CptPotato
Copy link
Contributor

@CptPotato CptPotato commented Sep 15, 2021 •
edited

Ports the "Dark Hard" variant of the Everforest theme to helix.

  • there were a few theme keys used in other themes that I didn't find documentation for
  • the usage of colors might be slightly different from the original (however, the palette's colors are the exact ones used in the original)
screenshot (not up to date anymore)

image

@CptPotato CptPotato force-pushed the everforest-theme branch 2 times, most recently from 04f2ed6 to 226e36c Compare September 17, 2021 07:59
@CptPotato CptPotato marked this pull request as ready for review September 17, 2021 08:03
@CptPotato
Copy link
Contributor Author

I'm mostly happy with how the theme looks now.

There are some deviations from the original one so I'm open to changes/suggestions.

@archseer
Copy link
Member

Thanks for the contribution! Feel free to add a preview to https://github.com/helix-editor/helix/wiki/Themes :)

@archseer archseer merged commit 70a20b7 into helix-editor:master Sep 17, 2021
@CptPotato
Copy link
Contributor Author

Thanks for the contribution! Feel free to add a preview to https://github.com/helix-editor/helix/wiki/Themes :)

I'll do that. Should I sort the themes alphabetically / group them by dark vs light?

@kirawi
Copy link
Member

kirawi commented Sep 17, 2021

I appended mine to the bottom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire left review comments

@kirawi kirawi kirawi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CptPotato @archseer @kirawi @pickfire