smartcase regex search #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraem
force-pushed
the
search_smart_case
branch
from
e852678
to
0ee3cca
Compare
archseer
requested changes
Sep 16, 2021
There was a problem hiding this comment.
What's the desired behaviour for select_regex? Never enabled? Configured with a separate option?
Default it to true.
Where would the regex builder live in helix-core?
Let's skip this for now, this PR is just a temporary workaround until we switch over to regex-automata in #211
kraem
force-pushed
the
search_smart_case
branch
from
0ee3cca
to
ab90261
Compare
|
Thanks :) Fixed your comments. Also took the liberty of removing the todo and a comment. |
kraem
force-pushed
the
search_smart_case
branch
from
ab90261
to
6f5b95b
Compare
|
Thanks! Looks like there's a conflict, and I'd also mention the new option in the configuration section of the book. Other than that it looks good for merge. |
kraem
force-pushed
the
search_smart_case
branch
from
6f5b95b
to
799334d
Compare
kraem
force-pushed
the
search_smart_case
branch
from
799334d
to
6d7da7b
Compare
kraem
force-pushed
the
search_smart_case
branch
from
6d7da7b
to
020de7c
Compare
archseer
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at smartcase search.
Some thoughts:
select_regex? Never enabled? Configured with a separate option?helix-core? (so it can be used for other ui:s than term and Initial implementation of global search #651)(edit: i didn't look at 651:s implementation before. guess the pr's not a reason for moving it to
helix-core..)