Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Pop-Dark: Increase Diagnostics clarity #7702

Merged
merged 2 commits into from Jul 26, 2023

Conversation

EricHenry
Copy link
Contributor

This PR is meant to make the hover diagnostics more legible by inverting the background and foreground color settings for info, warning, hint, and error.

Previously, it was not clear the status level of each item in the diagnostics picker. These changes fix that as well.
Before:
Screenshot 2023-07-21 at 10 01 55 PM

After:
Screenshot 2023-07-21 at 10 06 04 PM

@the-mikedavis
Copy link
Member

\cc @workingj what do you think?

@workingj
Copy link
Contributor

great! do it!
sry for the delay.

Copy link
Contributor

@workingj workingj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am fine with the changes!

@pascalkuthe pascalkuthe merged commit dea6894 into helix-editor:master Jul 26, 2023
6 checks passed
@pascalkuthe pascalkuthe added C-enhancement Category: Improvements A-theme Area: Theme and appearence related labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants