Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unison support #7724

Merged
merged 8 commits into from Aug 8, 2023
Merged

Add Unison support #7724

merged 8 commits into from Aug 8, 2023

Conversation

zetashift
Copy link
Contributor

Adds support for https://www.unison-lang.org/

I'll update the LSP docs when this PR gets merged.

@pascalkuthe
Copy link
Member

The grammar is missing the generated parser c code (parser.c). It needs to be checked into the repo or the repo can't be used with helix

@zetashift
Copy link
Contributor Author

The grammar is missing the generated parser c code (parser.c). It needs to be checked into the repo or the repo can't be used with helix

Yup, I've asked the maintainer through Slack if it could be added.
Want me to mark this PR as a draft until the meantime?

@pascalkuthe pascalkuthe added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 24, 2023
languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 7, 2023
@pascalkuthe pascalkuthe merged commit 294aa66 into helix-editor:master Aug 8, 2023
6 checks passed
chriskrycho added a commit to chriskrycho/nova-unison that referenced this pull request Aug 28, 2023
This pulls the queries and injections straight from the work done for
Helix in [this PR][1], from @zetashift. These should definitely be
upstreamed when possible! They also show up a few bugs in the grammar
as it stands, e.g. keywords get highlighted in the middle of
documentation blocks, where they should be ignored. Still: a start!

[1]: helix-editor/helix#7724
@zetashift zetashift deleted the add-unison-support branch September 1, 2023 22:37
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants