Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wren support #7819

Merged
merged 1 commit into from Aug 4, 2023
Merged

Conversation

Jummit
Copy link
Contributor

@Jummit Jummit commented Aug 3, 2023

This uses the improved grammar and adds queries for indenting, injections and locals, plus overall improvements.

Maybe this isn't the right place to ask this, but is there a reason why only parameters are highlighted a different color using the locals queries?

Example:

function test(a) {
  a // highlighted
  const b = 1
  b // not highlighted
}

I guess it's because it's less confusing?

@Jummit Jummit force-pushed the improve-wren branch 2 times, most recently from d4e3e30 to 3176b10 Compare August 4, 2023 08:56
@the-mikedavis
Copy link
Member

Locals queries allow the highlighting to track between definitions and references. a is @variable.parameter because when a is defined it's tagged as @variable.parameter. b is defined just as @variable on line 3 so all usages of b will also be @variable. Both are affected by the locals query but a is parameter.

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Aug 4, 2023
@pascalkuthe pascalkuthe merged commit f19793c into helix-editor:master Aug 4, 2023
6 checks passed
@Jummit Jummit deleted the improve-wren branch August 4, 2023 14:33
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants