Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: open file picker on directories using goto_file (gf) #7909

Merged
merged 2 commits into from Aug 15, 2023
Merged

feat: open file picker on directories using goto_file (gf) #7909

merged 2 commits into from Aug 15, 2023

Conversation

cbr9
Copy link
Contributor

@cbr9 cbr9 commented Aug 11, 2023 •
edited

Closes #7906.

Potential problems:

  • Relative paths are resolved with reference to the current working directory, instead of the file they are selected from (this was already the behavior, I tried to fix it but couldn't)

pascalkuthe
pascalkuthe requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. This makes gf matches :open

helix-term/src/commands.rs Outdated Show resolved Hide resolved
helix-term/src/commands.rs Outdated Show resolved Hide resolved
@cbr9
Copy link
Contributor Author

cbr9 commented Aug 11, 2023

I removed the helper and the canonicalize call

@the-mikedavis the-mikedavis added E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. A-command Area: Commands labels Aug 15, 2023
@pascalkuthe pascalkuthe merged commit 090a225 into helix-editor:master Aug 15, 2023
6 checks passed
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
@cbr9 @dgkf
goto_file: open picker if a directory is selected (helix-editor#7909)
92adddd 
* feat: open file picker on directories using goto_file (gf)

* remove helper and call to canonicalize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-command Area: Commands E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support opening a folder with goto_file
3 participants
@cbr9 @the-mikedavis @pascalkuthe