Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain the current cursor's position and view in the vsplit/hsplit commands too #8109

Merged
merged 3 commits into from Sep 4, 2023
Merged

Maintain the current cursor's position and view in the vsplit/hsplit commands too #8109

merged 3 commits into from Sep 4, 2023

Conversation

TheRealLorenz
Copy link
Contributor

Supersedes #7220.

bnjbvr and others added 2 commits August 29, 2023 09:45
@bnjbvr @TheRealLorenz
Maintain the current cursor's position and view in the vsplit/hsplit …
3e0aefe 
…commands too

Signed-off-by: Benjamin Bouvier <public@benj.me>
@TheRealLorenz
Fix clippy error
ffed075
@TheRealLorenz TheRealLorenz force-pushed the features/keep-position-in-split branch from 69024b3 to ffed075 Compare August 29, 2023 18:56
pascalkuthe
pascalkuthe requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core change lookms.gone to me but the diff should be +2-2, this contains a bunch unnecessary change that should be removed.

The extra docs can stay jf you are inclines but the changes to the sifnsfjre should be reverted.

helix-term/src/commands.rs Outdated Show resolved Hide resolved
@pascalkuthe pascalkuthe added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-command Area: Commands labels Aug 31, 2023
@pascalkuthe pascalkuthe added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2023
@archseer archseer merged commit e8fc77f into helix-editor:master Sep 4, 2023
12 checks passed
@TheRealLorenz TheRealLorenz deleted the features/keep-position-in-split branch September 4, 2023 08:58
acristoffers pushed a commit to acristoffers/helix that referenced this pull request Nov 18, 2023
@TheRealLorenz @bnjbvr @acristoffers
Maintain the current cursor's position and view in the vsplit/hsplit …
52369d1 
…commands too (helix-editor#8109)

Co-authored-by: Benjamin Bouvier <public@benj.me>
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
@TheRealLorenz @bnjbvr @dgkf
Maintain the current cursor's position and view in the vsplit/hsplit …
eeab18a 
…commands too (helix-editor#8109)

Co-authored-by: Benjamin Bouvier <public@benj.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabydd gabydd gabydd left review comments

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@archseer archseer Awaiting requested review from archseer

Assignees
No one assigned
Labels
A-command Area: Commands C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheRealLorenz @the-mikedavis @pascalkuthe @gabydd @archseer @bnjbvr