Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap yank command registers #8708

Merged
merged 1 commit into from Nov 4, 2023
Merged

swap yank command registers #8708

merged 1 commit into from Nov 4, 2023

Conversation

dead10ck
Copy link
Member

@dead10ck dead10ck commented Nov 3, 2023

#8703 swapped the + and * registers, but did not swap them in the corresponding yank commands.

pascalkuthe
pascalkuthe previously approved these changes Nov 3, 2023
View reviewed changes
@dead10ck
Copy link
Member Author

dead10ck commented Nov 3, 2023

shout out to calisti from the Matrix chat room for finding more places that needed to be swapped

@dead10ck
swap yank command registers
c7e054d 
helix-editor#8703 swapped the `+` and `*` registers, but did not swap them in the
corresponding yank commands.
@dead10ck dead10ck mentioned this pull request Nov 3, 2023
Merged
@mo8it
Copy link
Contributor

mo8it commented Nov 3, 2023

That should fix yank_joined_to_clipboard not yanking to the system clipboard since I compiled from source today 😅
I didn't test it though. I will test it after this PR gets merged.

Thanks for the fix 🥰

the-mikedavis
the-mikedavis approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked around for a while and I'm pretty sure this is all the places that need updating. Thanks for cleaning this up!

@the-mikedavis the-mikedavis added A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer. A-command Area: Commands labels Nov 3, 2023
@archseer archseer merged commit 10b178e into helix-editor:master Nov 4, 2023
6 checks passed
@archseer archseer deleted the fix-clipboard-swap branch November 4, 2023 00:35
acristoffers pushed a commit to acristoffers/helix that referenced this pull request Nov 18, 2023
@dead10ck @acristoffers
swap yank command registers (helix-editor#8708)
fb9348e 
helix-editor#8703 swapped the `+` and `*` registers, but did not swap them in the
corresponding yank commands.
danillos pushed a commit to danillos/helix that referenced this pull request Nov 21, 2023
@dead10ck @danillos
swap yank command registers (helix-editor#8708)
a929cbe 
helix-editor#8703 swapped the `+` and `*` registers, but did not swap them in the
corresponding yank commands.
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
@dead10ck @dgkf
swap yank command registers (helix-editor#8708)
54f7609 
helix-editor#8703 swapped the `+` and `*` registers, but did not swap them in the
corresponding yank commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe left review comments

@archseer archseer Awaiting requested review from archseer

Assignees
No one assigned
Labels
A-command Area: Commands A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dead10ck @mo8it @the-mikedavis @pascalkuthe @archseer