Fix precedence of ui.virtual.whitespace #8879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust ui.text description
atahrijouti
reviewed
Nov 22, 2023
the-mikedavis
approved these changes
Nov 25, 2023
pascalkuthe
approved these changes
Nov 25, 2023
|
I was expecting this PR to fix my issue with indent guides coloring, but looks like it doesn't? I've created #8909 to discuss more. |
kirawi
pushed a commit
to kirawi/helix
that referenced
this pull request
Dec 10, 2023
This reverts commit 8c68074.
kirawi
pushed a commit
to kirawi/helix
that referenced
this pull request
Dec 10, 2023
This reverts commit 8c68074.
kirawi
added a commit
to kirawi/helix
that referenced
this pull request
Jan 10, 2024
This reverts commit 8c68074.
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
* Revert "Revert "Fix precedence of ui.virtual.whitespace (helix-editor#8750)"" This reverts commit 811d62d. * Fix ui.text overwriting the syntax highlighting Adjust ui.text description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the first half of #5675, namely the whitespace case.
This is a patch up from #8750, which was reverted. Sorry for that.