Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): use crossterm cursor when at the end of the rope #8934

Merged
merged 1 commit into from Nov 28, 2023
Merged

fix(ui): use crossterm cursor when at the end of the rope #8934

merged 1 commit into from Nov 28, 2023

Conversation

hnorkowski
Copy link
Contributor

@hnorkowski hnorkowski commented Nov 28, 2023 •
edited

I found a missing special case for the out-of-focus crossterm cursor: When the block cursor is at the end of the rope it is not hidden.

the-mikedavis
the-mikedavis approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch, I forgot about this edge-case

@archseer archseer merged commit b023faa into helix-editor:master Nov 28, 2023
6 checks passed
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
@hnorkowski @dgkf
fix(ui): use crossterm cursor when at the end of the rope (helix-edit…
c50e404 
…or#8934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hnorkowski @the-mikedavis @archseer