fix :indent-style crash
#9087
Merged
fix :indent-style crash
#9087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't think of a better solution for the indent-auto-detecting function because I agree its implementation. |
the-mikedavis
changed the title
:indent-style crash and improve auto-indent-style-detection:indent-style crash
the-mikedavis
approved these changes
Dec 15, 2023
the-mikedavis
added
C-bug
|
I do still want to investigate the heuristic. I do think it can be improved and that this case was a bug indicative of larger issues I ran into before. |
|
I will merge this for now but we should investigate further |
pascalkuthe
approved these changes
Dec 15, 2023
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
* removing unreachable statement in `:indent-style` * update checks when setting indent line and update docs * `cargo xtask docgen`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9082