Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for SuperCollider #9329

Merged
merged 1 commit into from Mar 18, 2024

Conversation

pnelson
Copy link
Contributor

@pnelson pnelson commented Jan 13, 2024

Implements syntax highlighting for SuperCollider. See also #7368.

runtime/queries/supercollider/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/supercollider/indents.scm Outdated Show resolved Hide resolved
runtime/queries/supercollider/locals.scm Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Jan 15, 2024
@the-mikedavis the-mikedavis linked an issue Jan 15, 2024 that may be closed by this pull request
@pnelson
Copy link
Contributor Author

pnelson commented Jan 18, 2024

I touched up the highlights.scm and it's looking good when I run it on tutorial.scd but really struggled with the other tree-sitter files. Are highlights-only an acceptable breakpoint for this PR?

the-mikedavis
the-mikedavis previously approved these changes Jan 18, 2024
@the-mikedavis
Copy link
Member

Yep highlights-only is a good start 👍. The other queries can be contributed as follow-ups if anyone is interested in working on them

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 18, 2024
the-mikedavis
the-mikedavis previously approved these changes Feb 5, 2024
pascalkuthe
pascalkuthe previously approved these changes Mar 17, 2024
@pascalkuthe
Copy link
Member

needs a rebase

@pascalkuthe pascalkuthe merged commit 94d210c into helix-editor:master Mar 18, 2024
6 checks passed
@pnelson pnelson deleted the supercollider branch March 18, 2024 12:51
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
shortc pushed a commit to shortc/helix that referenced this pull request Mar 31, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supercollider support
3 participants