highlighting: Gate multiple captures behind #is-not? local predicates
#9390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
C-bug
flinesse
pushed a commit
to flinesse/helix
that referenced
this pull request
Jan 25, 2024
flinesse
pushed a commit
to flinesse/helix
that referenced
this pull request
Jan 25, 2024
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gleam-lang/tree-sitter-gleam#81
This is a part of tree-sitter/tree-sitter#1602 - I forgot to make this change to Helix after making it to tree-sitter-cli. If you have a pattern that has multiple captures and uses the
#is-not? localpredicate:; runtime/queries/gleam/highlights.scm ((field_access record: (identifier) @namespace field: (label) @function) (#is-not? local))the entire pattern should not apply if the
@namespace(i.e. the first) capture is not defined locally. To do that we need to remove the match so that the captures iterator doesn't return the remaining captures from the match in the future.