Adding two themes using only colors from 16-color terminal themes #9477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
A-theme
ascarter
reviewed
Jan 30, 2024
dgkf
force-pushed
the
term-palette-themes
branch
from
83a29e1
to
c94d9b1
Compare
ascarter
approved these changes
Feb 1, 2024
the-mikedavis
approved these changes
Feb 3, 2024
pascalkuthe
approved these changes
Feb 4, 2024
cosmikwolf
pushed a commit
to cosmikwolf/helix
that referenced
this pull request
Feb 26, 2024
…lix-editor#9477) * adding 16-color terminal themes * minor consistency update * minor consistency update * rename to be more consistent with other helix theme name conventions * fixing improper theme inherits name
shortc
pushed a commit
to shortc/helix
that referenced
this pull request
Mar 31, 2024
…lix-editor#9477) * adding 16-color terminal themes * minor consistency update * minor consistency update * rename to be more consistent with other helix theme name conventions * fixing improper theme inherits name
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…lix-editor#9477) * adding 16-color terminal themes * minor consistency update * minor consistency update * rename to be more consistent with other helix theme name conventions * fixing improper theme inherits name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two themes, using only the 16 color palette used for terminal themes.
This allows for the helix theme to match the terminal theme more consistently for those of us that like to have a helix pane open in a terminal multiplexer.
The theme style choices are meant to look best for palettes that reasonably adhere to the 8-color palette + 8 lighter variants. At least in kitty, many of the themes do not adhere to this style - the "lighter" color is often darker than the base color, or the "white" and "black" colors are swapped. I prioritized accommodating the themes that adhere more closely to the spec, so some of these deviating themes sometimes have quirks.
Here are some screenshots of some themes that adhere to the general ansi palette:
kittytheme (light)term16_darkterm16_light*Used "Higher Contrast" variant because the kitty default Solarized Dark uses grey for all the "light" variants