Implement key ordering for info box #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
reviewed
Nov 2, 2021
pickfire
approved these changes
Nov 2, 2021
Co-authored-by: Ivan Tham <pickfire@riseup.net>
|
Thanks! 🎉 |
gibbz00
added a commit
to gibbz00/helix
that referenced
this pull request
Jan 19, 2023
BTree was being used to store a list of keyevents for a given command. This list was only iterated over twice to in the end be converted to a Vec. Better to just use a Vec from start given the use- case. Temporalily reverts helix-editor#952.
gibbz00
added a commit
to gibbz00/helix
that referenced
this pull request
Jan 19, 2023
This, along with previous commit reverts regression in helix-editor#952
gibbz00
added a commit
to gibbz00/helix
that referenced
this pull request
Jan 22, 2023
BTree was being used to store a list of keyevents for a given command. This list was only iterated over twice to in the end be converted to a Vec. Better to just use a Vec from start given the use- case. Temporalily reverts helix-editor#952.
gibbz00
added a commit
to gibbz00/helix
that referenced
this pull request
Jan 22, 2023
This, along with previous commit reverts regression in helix-editor#952
gibbz00
added a commit
to gibbz00/helix
that referenced
this pull request
Jan 25, 2023
BTree was being used to store a list of keyevents for a given command. This list was only iterated over twice to in the end be converted to a Vec. Better to just use a Vec from start given the use- case. Temporalily reverts helix-editor#952.
gibbz00
added a commit
to gibbz00/helix
that referenced
this pull request
Jan 25, 2023
This, along with previous commit reverts regression in helix-editor#952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sorts the keys in the infobox, when multiple keys are associated to a command (or command group).
What previously looked like this:
now looks like this:
I also tried adding a padding to make everything align but I'm not sure if that's an improvement. If that is desired, I can add it to this PR:
