Add Support for JSONC #9906
Merged
Add Support for JSONC #9906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `vscode-json-language-server` accepts `jsonc` as a language id. Allowing the use of comments within JSON files.
the-mikedavis
added
S-waiting-on-author
the-mikedavis
previously approved these changes
Mar 17, 2024
|
To fix the docs CI you'll need to run |
the-mikedavis
approved these changes
Mar 17, 2024
the-mikedavis
added
S-waiting-on-review
pascalkuthe
approved these changes
Mar 17, 2024
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Mar 26, 2024
* Added `jsonc` language with support for comments The `vscode-json-language-server` accepts `jsonc` as a language id. Allowing the use of comments within JSON files. * fix: Update `injdection-rejex` to be unique * fix: use includes to remove redundant queries * ci: Generate language-support docs
shortc
pushed a commit
to shortc/helix
that referenced
this pull request
Mar 31, 2024
* Added `jsonc` language with support for comments The `vscode-json-language-server` accepts `jsonc` as a language id. Allowing the use of comments within JSON files. * fix: Update `injdection-rejex` to be unique * fix: use includes to remove redundant queries * ci: Generate language-support docs
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Added `jsonc` language with support for comments The `vscode-json-language-server` accepts `jsonc` as a language id. Allowing the use of comments within JSON files. * fix: Update `injdection-rejex` to be unique * fix: use includes to remove redundant queries * ci: Generate language-support docs
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Added `jsonc` language with support for comments The `vscode-json-language-server` accepts `jsonc` as a language id. Allowing the use of comments within JSON files. * fix: Update `injdection-rejex` to be unique * fix: use includes to remove redundant queries * ci: Generate language-support docs
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Added `jsonc` language with support for comments The `vscode-json-language-server` accepts `jsonc` as a language id. Allowing the use of comments within JSON files. * fix: Update `injdection-rejex` to be unique * fix: use includes to remove redundant queries * ci: Generate language-support docs
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
* Added `jsonc` language with support for comments The `vscode-json-language-server` accepts `jsonc` as a language id. Allowing the use of comments within JSON files. * fix: Update `injdection-rejex` to be unique * fix: use includes to remove redundant queries * ci: Generate language-support docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsoncis currently part of thejsonlanguage definition.This currently doesn't allow for comments to be added to the JSON. It is both linted as incorrect by the language server and not highlighted correctly.
The language server configured by the JSON language can take either
jsonorjsoncas valid language ids.Here is what the same file opened as a
.jsonclooks like in this PR: