Correctly handle normalization in pattern API #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
force-pushed
the
normalization
branch
from
caa8f26
to
eac298d
Compare
gabydd
reviewed
Dec 17, 2023
pascalkuthe
force-pushed
the
normalization
branch
from
eac298d
to
828b53d
Compare
pascalkuthe
force-pushed
the
normalization
branch
from
828b53d
to
34553f0
Compare
the-mikedavis
approved these changes
Dec 22, 2023
|
thanks @the-mikedavis and @gabydd for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real fix for #26 is to ensure that we disable normalization of the pattern has a umlaut/normalizable character. This is now handled similar to case folding. This is a breaking change. I decided to cut a 0.3.0 release for this.