Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more functionality from the token library #98

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Expose more functionality from the token library #98

merged 6 commits into from
Sep 13, 2022

Conversation

alexytsu
Copy link
Member

@alexytsu alexytsu commented Sep 8, 2022 •
edited
Loading

Makes the library a bit more flexible to be useful outside of straightforward FRC-46 token actors

@alexytsu alexytsu mentioned this pull request Sep 11, 2022
Closed
@alexytsu alexytsu marked this pull request as ready for review September 12, 2022 02:01
@alexytsu alexytsu changed the title expose functions on state Expose more functionality from the token library Sep 12, 2022
@coveralls
Copy link

coveralls commented Sep 12, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 75.805% when pulling d43f784 on token/state-methods into c7a6579 on main.

anorth
anorth reviewed Sep 12, 2022
View reviewed changes
fil_fungible_token/src/token/state.rs Outdated Show resolved Hide resolved
fil_fungible_token/src/token/mod.rs Outdated Show resolved Hide resolved
fil_fungible_token/src/token/mod.rs Show resolved Hide resolved
fil_fungible_token/src/token/mod.rs Outdated Show resolved Hide resolved
fil_fungible_token/src/token/state.rs Outdated Show resolved Hide resolved
anorth
anorth approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you agree with my remaining suggestions.

fil_fungible_token/src/token/mod.rs Outdated Show resolved Hide resolved
fil_fungible_token/src/token/mod.rs Outdated Show resolved Hide resolved
fil_fungible_token/src/token/mod.rs Show resolved Hide resolved
@alexytsu alexytsu merged commit 2c029ce into main Sep 13, 2022
@alexytsu alexytsu deleted the token/state-methods branch September 13, 2022 00:59
@anorth anorth mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anorth anorth anorth approved these changes

@abright abright Awaiting requested review from abright

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexytsu @coveralls @anorth