Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set types for dynamic request functions #17

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

fabio-nettis
Copy link
Member

Description

This PR resolves an issue with the type inference for the new Biome and Effect handlers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@fabio-nettis fabio-nettis added the bug Something isn't working label Apr 16, 2024
Copy link

Thank you for contributing to the HellHub SDK fellow Helldiver! We try to keep our bundle size as small as possible, here you can see the impact of your pull request to the main bundle.

📦 Main 🚀 PR 📁 Generated Files
4 kB 4 kB index.mjs / index.d.ts

The difference between the current bundle and the one generated for your pull request is: 0 kB. Keep in mind that this is just an estimation and the actual difference might be smaller due to compression.

@fabio-nettis fabio-nettis merged commit 68e2a32 into main Apr 16, 2024
4 checks passed
@fabio-nettis fabio-nettis deleted the fix/faulty-types branch April 16, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant