fix: Error when lineJoin is set to round (Orillusion#366)

* fix: Error when lineJoin is set to round Fix error when lineJoin is set to round. * fix: Remove eventListener. Remove the eventListener when transform is disposed.
hellmor · Mar 21, 2024 · 1ab8718 · 1ab8718
1 parent 7ab2f48
commit 1ab8718
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/graphic/compute/shape3d/Path2DShape3DCode_cs.ts b/packages/graphic/compute/shape3d/Path2DShape3DCode_cs.ts
@@ -442,10 +442,10 @@ fn drawPath2DCorner(shapeData:Path2DShape3D, currentPoint:Path3DKeyPoint){
             var rotateFrom:vec3<f32>;
             if(isPositive){
                 rotateFrom = -prevPoint.right;
-                rotateMat = buildRotateZ(-cornerAngle * 2.0 / f32(cornerPointExt));
+                rotateMat = buildRotateYMat3(-cornerAngle * 2.0 / f32(cornerPointExt));
             }else{
                 rotateFrom = prevPoint.right;
-                rotateMat = buildRotateZ(cornerAngle * 2.0 / f32(cornerPointExt));
+                rotateMat = buildRotateYMat3(cornerAngle * 2.0 / f32(cornerPointExt));
             }
     
             tempV = currentPoint.overallLength - cornerUVLength * lastLengthUVRatio;

diff --git a/src/components/gui/uiComponents/UITransform.ts b/src/components/gui/uiComponents/UITransform.ts
@@ -298,7 +298,7 @@ export class UITransform extends ComponentBase {
     }
 
     public beforeDestroy(force?: boolean): void {
-        this.transform.eventDispatcher.addEventListener(this.transform.eventLocalChange.type, this.onTransformChange, this);
+        this.transform.eventDispatcher.removeEventListener(this.transform.eventLocalChange.type, this.onTransformChange, this);
         super.beforeDestroy?.(force);
     }
 }