Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust zindex droppable logic #196

Closed
wants to merge 2 commits into from

Conversation

wibed
Copy link

@wibed wibed commented Mar 4, 2022

adjusted dropping logic on draggable to droppable container, by reversing the order from bottom to top to top to bottom as intuetively assumed

this results on draggables getting dropped into the topmost droppable instead into the lowest.

…sing the order from bottom to top to top to bottom as intuetively assumed
@100terres
Copy link
Collaborator

100terres commented Mar 11, 2022

Hi @wibed 👋

Thank you for your contribution! 👏

I would like to properly understand what we are trying do solve here 🎯

Would it be possible to open an issue detailing what's the current behavoir of rfd and what's you would expect rfd do instead. It would help me a lot review this PR, because I'm missing a bit of context. Also, it would be awesome, if you could provide a link to a CodeSandbox that shows the problem you are facing 🙂

Thank you again!

@100terres 100terres added enhancement New feature or request question Further information is requested labels Mar 11, 2022
@wibed
Copy link
Author

wibed commented Mar 14, 2022

@100terres

i understand that the repo is in reconstruction and taking up the pace can be daunting.

if you take a peak at the commit, my only doing is reversing the order the droppable is alotted.
atm it does order the droppable to drop to from bottom to top, dropping it into the first it can find.

this results in case of overlapping droppables for the lowest droppable to be used instead of, as mentioned, intuetively
assumed, highest droppable in the order.

this is fixed by reversing the order on the array.

@100terres
Copy link
Collaborator

I'll close this PR for now since no issue were opened and no CodeSandbox link were provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants