Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing libfm-qt files #89

Closed
wants to merge 3 commits into from
Closed

Conversation

kettle-7
Copy link

@kettle-7 kettle-7 commented May 2, 2021

These files are taken directly from https://github.com/lxqt/libfm-qt, and contain C++ files and headers for handling file operations.

Somehow @probonopd managed to compile Filer without them, I'm assuming that's because he had the files already in /usr/include.

Anyway, these can now be modified to help fix issue #53.

linuxkettle and others added 3 commits May 2, 2021 05:39
@probonopd
Copy link
Member

probonopd commented May 2, 2021

@linuxkettle I really doubt that this is necessary. If we would really need this, how come that we can compile Filer without it like this:
https://github.com/helloSystem/Filer/blob/master/.github/workflows/build.yml

Somehow @probonopd managed to compile Filer without them, I'm assuming that's because he had the files already in /usr/include.

In this case they would have to come from one of the packages specified in the yml file. They can't appear out of thin air ;-)

@kettle-7
Copy link
Author

kettle-7 commented May 2, 2021

That is strange. If Filer doesn't need these headers to compile, where could it get the function definitions from? I forgot to run grep in /usr/local/include, but when I did, it came up with exact copies of these files.

I'm no C++ expert, but I do know two things: files can't appear out of thin air (so Filer mustn't need these files) and functions need definitions (so Filer must need these files)

Confusing!

@probonopd probonopd closed this May 2, 2021
@probonopd
Copy link
Member

So we both need to keep looking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants