Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in the Menu doesn't work with KWin #234

Closed
ericprd opened this issue Jul 6, 2021 · 10 comments
Closed

Search in the Menu doesn't work with KWin #234

ericprd opened this issue Jul 6, 2021 · 10 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ericprd
Copy link

ericprd commented Jul 6, 2021

Tried to type something on the search bar but it doesn't show any feedback, and when trying to hover my pointer to top left corner it's showing like in the picture.

Run on livecd
PXL_20210706_122943322

@ericprd ericprd added the bug Something isn't working label Jul 6, 2021
@probonopd
Copy link
Member

Regarding the visual glitch:

This is how it should look like when you move the mouse cursor all the way into the corner:

image

We are probably missing an asset in KWin.
helloSystem/hello#164

Regarding the search:

Please click into the blue area further right (not in the corner) and type, e.g., "Computer". Does it show anything?

@ericprd
Copy link
Author

ericprd commented Jul 7, 2021

No, it doesn't show anything. Even using alt+space then type, it doesn't show any

@probonopd
Copy link
Member

Which exact version of helloSystem are you using, are you running it Live or installed?

@ericprd
Copy link
Author

ericprd commented Jul 8, 2021

The latest one, 0F27. I run it Live.

@probonopd
Copy link
Member

probonopd commented Jul 8, 2021

I can reproduce this on the experimental Live ISO. Possibly a side effect of using KWin.app. (This does not happen on my local dev machine where I use a fully installed kwin_x11).

Reference:
helloSystem/hello#164

@probonopd probonopd changed the title Search bar on the top panel doesn't work Search in the Menu doesn't work with KWin Jul 18, 2021
@probonopd
Copy link
Member

probonopd commented Jul 18, 2021

Tested the following on my local development machine where it normally works:

  • Kill Menu
  • Kill KWin
  • launch KWin
  • launch Menu

--> Search box does not work

  • Kill KWin --> Search works again

On my local development machine where it normally works things get started in start-hello iike this:

# Menubar
export GTK_MODULES=appmenu-gtk-module
/System/Menu.AppDir/usr/bin/menubar & # FIXME: Use AppRun

kwin_x11 &

But starting it like this once the session is already running does not fix this either.

Some sort of timing issue? Or dependent on what other processes are already running?

@probonopd
Copy link
Member

probonopd commented Jul 18, 2021

Looks like this is caused by KWindowSystem::setType(winId(), NET::Dock);.
We are using KWindowSystem::setType(winId(), NET::Dock); because otherwise the Menu gets drawn outside (below) the screen area that is reserved for the Menu when KWin is already running at the time when the Menu is launched.

image

Is there a way to get it drawn in the correct place even when KWin is already running without using KWindowSystem::setType(winId(), NET::Dock);?

If we remove the KWindowSystem::setType(winId(), NET::Dock); then the Search box will work with KWin but the Menu will be in the wrong position if the Menu is launched after KWin.

@probonopd
Copy link
Member

Another option would probably be to make the Search box its own window. It would be painted over the exact same location so as to give the impression that it is part of the Menu bar.

@probonopd probonopd added the help wanted Extra attention is needed label Jul 18, 2021
probonopd added a commit to helloSystem/Utilities that referenced this issue Sep 16, 2021
probonopd added a commit to helloSystem/Utilities that referenced this issue Sep 16, 2021
@probonopd
Copy link
Member

Let's see if build 0F34 improves this.

@probonopd
Copy link
Member

probonopd commented Sep 17, 2021

Search tested on https://github.com/helloSystem/ISO/releases/tag/experimental-12.2, works for me now. Regarding the cosmetic glitch in the top-left corner let's continue at helloSystem/KWin#2. Thanks @wesbluemarine for pointing in this direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants