Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or rename the badge and use_li parameters in the render_nav_item macro #215

Closed
greyli opened this issue Feb 27, 2022 · 0 comments · Fixed by #238
Closed

Remove or rename the badge and use_li parameters in the render_nav_item macro #215

greyli opened this issue Feb 27, 2022 · 0 comments · Fixed by #238
Labels
enhancement New feature or request

Comments

@greyli
Copy link
Member

greyli commented Feb 27, 2022

Remove the badge and use_li parameters or rename them to _badge/_use_li, so they won't shadow user's keyword arguments.

  • Add a deprecation warning in 2.1.0
  • Remove or rename them in 2.2.0
@greyli greyli added the enhancement New feature or request label Feb 27, 2022
@greyli greyli mentioned this issue Aug 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename parameters of render_nav_item helloflask/bootstrap-flask
1 participant
@greyli