Rename parameters of render_nav_item #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the following parameters of the `render_nav_item` macro to prevent shadowing user's URL variables. - badge -> _badge - use_li -> _use_li I didn't find the way to emit a deprecate warning in a macro. So this change will release with the 2.1 version directly.
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 1 1
Lines 134 134
Branches 23 23
=======================================
Hits 130 130
Misses 1 1
Partials 3 3 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the following parameters of the
render_nav_itemmacro to prevent shadowing the user's URL variables.fixes: #215
I didn't find the way to emit a deprecate warning in a macro. So this change will release with the 2.1 version directly.