Skip to content
This repository has been archived by the owner on Aug 25, 2022. It is now read-only.

PT-1562 Allow declaring non-durable exchanges #36

Merged
merged 4 commits into from
Jul 30, 2018

Conversation

vgarvardt
Copy link
Contributor

@vgarvardt vgarvardt commented Jul 30, 2018

What this PR changes:

Added rabbitTransientExchange property to pipe definition to declare transient (non-durable) exchanges.

Property is called in this way, not the rabbitDurableExchange, because of the default golang bool value for BC compatibility - in the current stabel version exchange is always declared as durable, so old pipes configs missing this new property will remain non-transient.

PS: additionally bumped all the dependencies to the latest stabe verisons

Refs #35

@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files           7        7           
  Lines         222      222           
=======================================
  Hits          160      160           
  Misses         56       56           
  Partials        6        6
Impacted Files Coverage Δ
pkg/config/pipes.go 84.61% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292143b...9839e5e. Read the comment docs.

@vgarvardt vgarvardt changed the title PT-1562 Feature/use existing exchange PT-1562 Allow declaring non-durable exchanges Jul 30, 2018
@antonu17
Copy link

antonu17 commented Jul 30, 2018

+1

Approved with PullApprove Approved with PullApprove Approved with PullApprove

@vgarvardt vgarvardt merged commit d31c6fd into master Jul 30, 2018
@vgarvardt vgarvardt deleted the feature/use-existing-exchange branch July 30, 2018 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants