fix: Do not use self-closing tags in HTML markup

We've found that it confuses some engines, like Salesforce
hellosign · May 18, 2021 · 9520b39 · 9520b39
1 parent 0234daf
commit 9520b39
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/embedded.js b/src/embedded.js
@@ -439,7 +439,7 @@ class HelloSign extends Emitter {
     if (this._config.container) {
       elem.innerHTML = safeHtml`
         <div class="${settings.classNames.BASE}">
-          <iframe class="${settings.classNames.IFRAME}" name="${settings.iframe.NAME}" src="${this._iFrameURL.href}" scrolling="no" />
+          <iframe class="${settings.classNames.IFRAME}" name="${settings.iframe.NAME}" src="${this._iFrameURL.href}" scrolling="no"></iframe>
         </div>
       `;
     } else {
@@ -454,7 +454,7 @@ class HelloSign extends Emitter {
           </div>
         ` : ''
       ) + safeHtml`
-            <iframe class="${settings.classNames.IFRAME}" name="${settings.iframe.NAME}" src="${this._iFrameURL.href}" scrolling="no" />
+            <iframe class="${settings.classNames.IFRAME}" name="${settings.iframe.NAME}" src="${this._iFrameURL.href}" scrolling="no"></iframe>
           </div>
         </div>
       `;