Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Select crop region in main image viewer #48

Open
alancutter opened this issue Oct 24, 2018 · 1 comment
Open

Feature request: Select crop region in main image viewer #48

alancutter opened this issue Oct 24, 2018 · 1 comment

Comments

@alancutter
Copy link

Selecting a portion of a screenshot to crop is very difficult to do when the crop preview is so small compared with the size of the image. It would be great if cropping could be done in the primary image viewport.
screenshot from 2018-10-24 13-41-49

@ghost
Copy link

ghost commented Dec 29, 2018

@alancutter
As a work-around I can propose you the following patch. It does not implement the feature you want, but makes the crop dialog bigger.

 src/vnr-crop.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/vnr-crop.c b/src/vnr-crop.c
index 76bdd48..98417f8 100644
--- a/src/vnr-crop.c
+++ b/src/vnr-crop.c
@@ -122,7 +122,10 @@ vnr_crop_build_dialog (VnrCrop *crop)
     width = crop->vnr_win->current_image_width;
     height = crop->vnr_win->current_image_height;
 
-    vnr_tools_fit_to_size_double(&height, &width, 400,400);
+    gint scr_height = gdk_screen_get_height (gtk_window_get_screen (GTK_WINDOW(window)));
+    scr_height -= scr_height * 0.3;
+
+    vnr_tools_fit_to_size_double(&height, &width, scr_height, scr_height * 2);
     crop->width = width;
     crop->height = height;
     crop->zoom = ( width/crop->vnr_win->current_image_width

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants