Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SONiC VM support #214

Closed
wants to merge 3 commits into from
Closed

Conversation

adam-kulagowski
Copy link

This pull request will be followed up by PR in https://github.com/srl-labs/containerlab . The aim is to add SONiC VM support as a docker version of SONiC is severely limited/broken. The code itself is mostly a compilation of python/bash scripts from VSRX and FreeBSD directories.

If anything is missing please let me know.

@adam-kulagowski
Copy link
Author

Corresponding PR: srl-labs/containerlab#2114

@hellt
Copy link
Owner

hellt commented Jun 28, 2024

Thanks @adam-kulagowski !
I will try to get this reviewed beginning of next week

- bad directory name
- major issues reported by DeepSource
@hellt
Copy link
Owner

hellt commented Jun 28, 2024

(you can close an eye on deepsource, I will remove it later on)

- fixes default password
- readded shell=true
sonic/README.md Show resolved Hide resolved
@hellt
Copy link
Owner

hellt commented Jul 3, 2024

merged in #220
thank you @adam-kulagowski

@hellt hellt closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants