Wrong variable prevents from finding correct tools #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
|
@jdolitsky Since you just merged my other PR, I thought maybe you missed this one. This one is important because of the typo in the name of the VENV_DIR variable. Thanks! |
|
👍 |
pmacik
added a commit
to pmacik/acceptance-testing
that referenced
this pull request
Nov 3, 2020
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pratikjagrut
pushed a commit
to pratikjagrut/acceptance-testing
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik
added a commit
to pmacik/acceptance-testing
that referenced
this pull request
Aug 23, 2022
…m commits -update pip to pip3 -run openshift tests -Fix test data deployment version -Install PV before test setup and fix deamon set tests -Add helm dir in .acceptance -Change to use current helm bin -Disable test for version greater than 3.1 -Create blank.yml -Enable tests related to Helm 3.2 bin. (helm#2) -Add openshift cluster provider (helm#6) * Run acceptance tests against provided k8s cluster * Add openshift cluster provider -Fix kubeVersion to support kube pre-releases (helm/helm#6190) (helm#9) -Remove obsolete and redundand test cases from kubernetes_versions.robot (helm#12) -Adjust completion test according to helm 3.4 flags (helm#11) -Fixes the completion tests failure by adjusting tests according to new changes flags changes in helm 3.4. Co-authored-by: Akash Shinde <akashshinde159@gmail.com> Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My pip installation is for python2 so things didn't work until the PATH was properly set to point to the virtualenv bin directory which has pip installed for python3.
Also, I had forgotten to send stderr to /dev/null when checking for helm v3, so there was an error printout that might have been confusing.
Now
make acceptancepasses for me 😄