Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps #215

Merged
merged 1 commit into from Sep 26, 2022
Merged

update deps #215

merged 1 commit into from Sep 26, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 26, 2022

  • update deps

Signed-off-by: cpanato <ctadeu@gmail.com>
@@ -163,6 +159,6 @@ require (
)

replace (
github.com/docker/distribution => github.com/docker/distribution v0.0.0-20191216044856-a8371794149d
github.com/docker/docker => github.com/moby/moby v17.12.0-ce-rc1.0.20200618181300-9dc6525e6118+incompatible
github.com/docker/distribution => github.com/docker/distribution v2.8.1+incompatible
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this replacement needed as it points to same location?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can drop, was there before maybe to use that always

Copy link
Member

@davidkarlsen davidkarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but wondering about the comment

@cpanato cpanato merged commit 9b2308b into helm:main Sep 26, 2022
@cpanato cpanato deleted the update-deps branch September 26, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants