Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept generate_release_notes in github api upload to automatically g… #229

Merged
merged 2 commits into from Jan 4, 2023
Merged

accept generate_release_notes in github api upload to automatically g… #229

merged 2 commits into from Jan 4, 2023

Conversation

bukowa
Copy link
Contributor

@bukowa bukowa commented Nov 3, 2022

rebased in new PR beacuse i dont know git #219

@bukowa
accept generate_release_notes in github api upload to automatically g…
981725f 
…enerate changelog

Signed-off-by: Buk Bukowski <gitbukowa@gmail.com>
@bukowa bukowa mentioned this pull request Nov 3, 2022
Closed
@nikolaik
Copy link

nikolaik commented Jan 4, 2023

This is wonderful! Is there anything holding back this PR?

@nikolaik nikolaik mentioned this pull request Jan 4, 2023
Closed
@cpanato cpanato closed this Jan 4, 2023
@cpanato cpanato reopened this Jan 4, 2023
@cpanato
Copy link
Member

cpanato commented Jan 4, 2023

@bukowa i will rebase this PR to trigger CI

@cpanato
Copy link
Member

cpanato commented Jan 4, 2023

This is wonderful! Is there anything holding back this PR?

need to find a bit of time to test it

@cpanato
Copy link
Member

cpanato commented Jan 4, 2023

@bukowa i will rebase this PR to trigger CI

ok, I dont have the permissions to push to your repo, please rebase the PR

@bukowa
Merge branch 'main' into genreleasenotes
cf74742 
Signed-off-by: Buk Bukowski <38087302+bukowa@users.noreply.github.com>
@bukowa
Copy link
Contributor Author

bukowa commented Jan 4, 2023

@bukowa i will rebase this PR to trigger CI

ok, I dont have the permissions to push to your repo, please rebase the PR

Hey i resolved conflicts using github ui and gave you write permission to the repo just in case.

@cpanato
Copy link
Member

cpanato commented Jan 4, 2023

@bukowa i will rebase this PR to trigger CI

ok, I dont have the permissions to push to your repo, please rebase the PR

Hey i resolved conflicts using github ui and gave you write permission to the repo just in case.

thanks!
you don't need to give permission in your fork, in the PR there is an option to check and that grants permission for the PR

Screenshot 2023-01-04 at 17 31 02

cpanato
cpanato approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato merged commit 3719ff6 into helm:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkarlsen davidkarlsen davidkarlsen approved these changes

@cpanato cpanato cpanato approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bukowa @nikolaik @cpanato @davidkarlsen