Ignore third party files added in the release. #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpanato I've fixed some linter issues. Can you trigger the CI again? |
unguiculus
previously requested changes
Nov 25, 2022
jvanz
requested review from
unguiculus
and removed request for
davidkarlsen and
cpanato
cpanato
approved these changes
Nov 29, 2022
|
@jvanz please fix the lints and push it again, also can you squash all commits? thanks |
Update the function used to update the index to ignore any file that does not have the chart asset file extension (.tgz). This is necessary because chart-release fails with users add another kind of files in chart release. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
davidkarlsen
force-pushed
the
issue233
branch
from
1a0220f
to
48e9368
Compare
|
@davidkarlsen, thanks for the quick fix. |
|
@unguiculus I think we need your approval to move forward. :) |
cpanato
approved these changes
Nov 29, 2022
|
🥳 |
|
@cpanato , @unguiculus , @davidkarlsen is it possible to release a new version of the chart-releaser? Thus, I can update the github action to has this fix as well. |
|
i will chck other prs this week and we can release in the end of the week |
|
Great, thanks! |
|
need a bit more time 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the function used to update the index to ignore any file that does not have the chart asset file extension (.tgz). This is necessary because chart-release fails with users add another kind of files in chart release.
Fix #233