Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm dependency to v3.4.0 #82

Merged
merged 7 commits into from Oct 29, 2020

Conversation

unguiculus
Copy link
Member

Signed-off-by: Reinhard Nägele unguiculus@gmail.com

Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

magefile.go Outdated
if err := sh.RunV("git", "diff", "--exit-code"); err != nil {
return err
}
// Run after git diff check because it produces random changes different from when run locally
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to change it again. go.mod changes also. Weird.

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
@helm-bot helm-bot added size/M and removed size/S labels Oct 29, 2020
@unguiculus unguiculus merged commit 877bf85 into helm:master Oct 29, 2020
@unguiculus unguiculus deleted the feature/helm-version branch October 29, 2020 17:56
@scottrigby
Copy link
Member

Nice find. For future ref, this fix is from ory/dockertest#212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants