New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Helm dependency to v3.4.0 #82
Conversation
32d694f
to
346dc7a
Compare
346dc7a
to
44a7776
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
magefile.go
Outdated
if err := sh.RunV("git", "diff", "--exit-code"); err != nil { | ||
return err | ||
} | ||
// Run after git diff check because it produces random changes different from when run locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to change it again. go.mod changes also. Weird.
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
44a7776
to
02168a5
Compare
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Nice find. For future ref, this fix is from ory/dockertest#212 |
Signed-off-by: Reinhard Nägele unguiculus@gmail.com