Construct pushURL from remote instead of hardcoding github.com #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reed Palmer <reed.d.palmer@gmail.com>
|
closes #91 |
Signed-off-by: Reed Palmer <reed.d.palmer@gmail.com>
unguiculus
requested changes
Feb 17, 2021
| return "", err | ||
| } | ||
|
|
||
| pushURLArray := strings.SplitAfter(strings.TrimSpace(string(pushURL)), "https://") |
There was a problem hiding this comment.
This probably won't work for SSH URLs. Please add a test that verifies the functionality for both, SSH and HTTPS URLs.
There was a problem hiding this comment.
You're right regarding SSH. That's not supported and a token is needed for pushing. chart-releaser is usually used with GitHub Actions which don't use SSH anyways.
|
Thanks for the review @unguiculus. I will pick this back up soon. FWIW, the original functionality did not work with SSH either, but regardless it would be good to support, and I should add tests. |
|
@rdpa i run into the same issue any news on that? |
|
Any updates on this one? Having the same issue here. |
Signed-off-by: Reed Palmer <reed.d.palmer@gmail.com>
Signed-off-by: Reed Palmer <reed.d.palmer@gmail.com>
|
@unguiculus tests added |
cpanato
approved these changes
Apr 8, 2021
unguiculus
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.